New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, plan: rewrite builtin funcs setvar, getvar #4479

Merged
merged 6 commits into from Sep 11, 2017

Conversation

Projects
None yet
5 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Sep 8, 2017

@zz-jason zz-jason referenced this pull request Sep 8, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 11, 2017

Contributor

PTAL @zz-jason

Contributor

XuHuaiyu commented Sep 11, 2017

PTAL @zz-jason

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 11, 2017

Member

@XuHuaiyu ci failed.

Member

zz-jason commented Sep 11, 2017

@XuHuaiyu ci failed.

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 11, 2017

Contributor

Fixed PTAL @zz-jason

Contributor

XuHuaiyu commented Sep 11, 2017

Fixed PTAL @zz-jason

@zz-jason

LGTM

@hanfei1991 hanfei1991 merged commit 0fd962f into master Sep 11, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the xhy/setvar/getvar branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment