New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: rewrite builtin function ROW && remove `Datum.KindRow` #4480

Merged
merged 13 commits into from Sep 11, 2017

Conversation

Projects
None yet
5 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Sep 8, 2017

*: 1.rewrite builtin row
2. remove Datum.KindRow

@zz-jason zz-jason referenced this pull request Sep 8, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Sep 8, 2017

to #4336

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 8, 2017

Member

@XuHuaiyu ci failed.

Member

zz-jason commented Sep 8, 2017

@XuHuaiyu ci failed.

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 8, 2017

Member

When do we still need row function ?

Member

hanfei1991 commented Sep 8, 2017

When do we still need row function ?

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 11, 2017

Member

LGTM

Member

hanfei1991 commented Sep 11, 2017

LGTM

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 11, 2017

Contributor

@zz-jason PTAL

Contributor

XuHuaiyu commented Sep 11, 2017

@zz-jason PTAL

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 11, 2017

Contributor

PTAL @zz-jason

Contributor

XuHuaiyu commented Sep 11, 2017

PTAL @zz-jason

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Sep 11, 2017

@zz-jason zz-jason changed the title from *: 1.rewrite builtin row 2. remove Datum.KindRow to *: rewrite builtin function ROW && remove `Datum.KindRow` Sep 11, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 11, 2017

Member

@XuHuaiyu ci failed.

Member

zz-jason commented Sep 11, 2017

@XuHuaiyu ci failed.

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 11, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Sep 11, 2017

/run-all-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 11, 2017

Member

/run-all-test

Member

zz-jason commented Sep 11, 2017

/run-all-test

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 11, 2017

Contributor

/run-integration-common-test
/run-integration-ddl-test

Contributor

XuHuaiyu commented Sep 11, 2017

/run-integration-common-test
/run-integration-ddl-test

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 11, 2017

Contributor

/run-integration-ddl-test tikv=latest

Contributor

XuHuaiyu commented Sep 11, 2017

/run-integration-ddl-test tikv=latest

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 11, 2017

Contributor

/run-integration-common-test
/run-integration-ddl-test

Contributor

XuHuaiyu commented Sep 11, 2017

/run-integration-common-test
/run-integration-ddl-test

@zz-jason zz-jason merged commit 4295780 into master Sep 11, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the xhy/row branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment