New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: implement analyze index push down #4489

Merged
merged 9 commits into from Sep 14, 2017

Conversation

Projects
None yet
4 participants
@lamxTyler
Member

lamxTyler commented Sep 11, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 11, 2017

Member

Need to verify that the push down is used.

Member

coocood commented Sep 11, 2017

Need to verify that the push down is used.

Show outdated Hide outdated executor/builder.go
Show outdated Hide outdated executor/new_analyze.go
Show outdated Hide outdated executor/new_analyze.go
Show outdated Hide outdated executor/new_analyze.go
Show outdated Hide outdated executor/analyze.go
Show outdated Hide outdated executor/new_analyze.go
}()
hist = &statistics.Histogram{}
for {
data, err := e.result.NextRaw()

This comment has been minimized.

@tiancaiamao

tiancaiamao Sep 13, 2017

Contributor

NextRaw and Next is basically the same thing.
Why not reuse distsql.SelectDAG and just add a new request subtype?

@tiancaiamao

tiancaiamao Sep 13, 2017

Contributor

NextRaw and Next is basically the same thing.
Why not reuse distsql.SelectDAG and just add a new request subtype?

This comment has been minimized.

@coocood

coocood Sep 13, 2017

Member

distsql.SelectDAG sends DAGRequest, distsql.Analyze sends AnalyzeReq.

@coocood

coocood Sep 13, 2017

Member

distsql.SelectDAG sends DAGRequest, distsql.Analyze sends AnalyzeReq.

This comment has been minimized.

@tiancaiamao

tiancaiamao Sep 13, 2017

Contributor

If you take a close look, distsql.SelectDAG and distsql.Analyze are identical, excepting that one send

kv.Request{Tp:             kv.ReqTypeDAG}

another send

kv.Request{Tp:             kv.ReqTypeAnalyze}

Personally, I dislike redundant code and the additional NextRaw method to the interface.
But they're already introduced in previous commit.

@tiancaiamao

tiancaiamao Sep 13, 2017

Contributor

If you take a close look, distsql.SelectDAG and distsql.Analyze are identical, excepting that one send

kv.Request{Tp:             kv.ReqTypeDAG}

another send

kv.Request{Tp:             kv.ReqTypeAnalyze}

Personally, I dislike redundant code and the additional NextRaw method to the interface.
But they're already introduced in previous commit.

This comment has been minimized.

@coocood

coocood Sep 13, 2017

Member

Analyze request is hard to be adapted to DAGRequest.

@coocood

coocood Sep 13, 2017

Member

Analyze request is hard to be adapted to DAGRequest.

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Sep 13, 2017

Contributor

LGTM @coocood

Contributor

tiancaiamao commented Sep 13, 2017

LGTM @coocood

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 13, 2017

Member

LGTM

Member

coocood commented Sep 13, 2017

LGTM

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 13, 2017

Member

/run-all-test

Member

coocood commented Sep 13, 2017

/run-all-test

@lamxTyler

This comment has been minimized.

Show comment
Hide comment
@lamxTyler

lamxTyler Sep 14, 2017

Member

/run-all-test

Member

lamxTyler commented Sep 14, 2017

/run-all-test

@lamxTyler lamxTyler merged commit a7dc21c into master Sep 14, 2017

10 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lamxTyler lamxTyler deleted the xhb/idx branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment