New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support signature push down. #4495

Merged
merged 24 commits into from Sep 25, 2017

Conversation

Projects
None yet
8 participants
@hanfei1991
Member

hanfei1991 commented Sep 11, 2017

  1. push more signatures, open the switch.
  2. like always accepts 3 args.
  3. add type info to column and constant pb.
@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991
Member

hanfei1991 commented Sep 14, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 18, 2017

Contributor

please resolve the conflicts.
rest LGTM

Contributor

XuHuaiyu commented Sep 18, 2017

please resolve the conflicts.
rest LGTM

@@ -916,7 +916,7 @@ var funcs = map[string]functionClass{
ast.UnaryMinus: &unaryMinusFunctionClass{baseFunctionClass{ast.UnaryMinus, 1, 1}},
ast.IsTruth: &isTrueOrFalseFunctionClass{baseFunctionClass{ast.IsTruth, 1, 1}, opcode.IsTruth},
ast.IsFalsity: &isTrueOrFalseFunctionClass{baseFunctionClass{ast.IsFalsity, 1, 1}, opcode.IsFalsity},
ast.Like: &likeFunctionClass{baseFunctionClass{ast.Like, 2, 3}},
ast.Like: &likeFunctionClass{baseFunctionClass{ast.Like, 3, 3}},

This comment has been minimized.

@zz-jason

zz-jason Sep 18, 2017

Member

bug fix ?

@zz-jason

zz-jason Sep 18, 2017

Member

bug fix ?

This comment has been minimized.

@hanfei1991

hanfei1991 Sep 18, 2017

Member

no, it's a compatible problem.

@hanfei1991

hanfei1991 Sep 18, 2017

Member

no, it's a compatible problem.

Show outdated Hide outdated store/tikv/coprocessor.go Outdated

hanfei1991 and others added some commits Sep 20, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 21, 2017

Member

/run-all-test tikv=shirly/dag_expression

Member

coocood commented Sep 21, 2017

/run-all-test tikv=shirly/dag_expression

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros

winoros Sep 21, 2017

Member

@coocood Currently tikv= can only use master/pre-ga/rc4... branch.

Member

winoros commented Sep 21, 2017

@coocood Currently tikv= can only use master/pre-ga/rc4... branch.

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 21, 2017

Member

/rebuild

Member

iamxy commented Sep 21, 2017

/rebuild

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 21, 2017

Member

/run-all-test

Member

iamxy commented Sep 21, 2017

/run-all-test

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 21, 2017

Member

/run-integration-test tikv=shirly/dag_expression

Member

coocood commented Sep 21, 2017

/run-integration-test tikv=shirly/dag_expression

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 21, 2017

Member

/rebuild

Member

iamxy commented Sep 21, 2017

/rebuild

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 21, 2017

Member

/run-integration-common-test tikv=shirly/dag_expression

Member

iamxy commented Sep 21, 2017

/run-integration-common-test tikv=shirly/dag_expression

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 25, 2017

Member

@hanfei1991 Please resolve the conflicts and remove the DNM label.

Member

shenli commented Sep 25, 2017

@hanfei1991 Please resolve the conflicts and remove the DNM label.

XuHuaiyu added some commits Sep 25, 2017

Merge branch 'master' of https://github.com/pingcap/tidb into hanfei/ci
Conflicts:
	expression/builtin_arithmetic.go
	expression/builtin_compare.go
	expression/builtin_control.go
	expression/builtin_like.go
	expression/builtin_op.go
	expression/distsql_builtin.go
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 25, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Sep 25, 2017

/run-all-test

@coocood

LGTM

@coocood coocood merged commit 45bdd69 into master Sep 25, 2017

10 of 11 checks passed

jenkins-ci-tidb/mybatis-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.727%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the hanfei/ci branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment