New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support nvarchar syntax #4500

Merged
merged 4 commits into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@winkyao
Member

winkyao commented Sep 12, 2017

fix #4497

winkyao added some commits Sep 12, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Sep 12, 2017

@winoros

add test in parser_test.go?
rest LGTM

@winkyao winkyao added the status/LGT1 label Sep 12, 2017

@breeswish

This comment has been minimized.

Show comment
Hide comment
@breeswish

breeswish Sep 12, 2017

Member

LGTM

Member

breeswish commented Sep 12, 2017

LGTM

@breeswish breeswish added status/LGT2 and removed status/LGT1 labels Sep 12, 2017

@breeswish breeswish merged commit e61efe6 into master Sep 12, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@breeswish breeswish deleted the winkyao/support_nvarchar branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment