New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: support aggregation function contains aggregation function #4511

Merged
merged 2 commits into from Sep 18, 2017

Conversation

Projects
None yet
4 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Sep 13, 2017

@@ -46,11 +46,6 @@ type validator struct {
func (v *validator) Enter(in ast.Node) (out ast.Node, skipChildren bool) {
switch node := in.(type) {
case *ast.AggregateFuncExpr:
if v.inAggregate {

This comment has been minimized.

@winkyao

winkyao Sep 13, 2017

Member

is it safe to remove these ?

@winkyao

winkyao Sep 13, 2017

Member

is it safe to remove these ?

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Sep 13, 2017

Contributor

This is a grammar check, I'm not sure why we abandon this before.
@shenli PTAL

@XuHuaiyu

XuHuaiyu Sep 13, 2017

Contributor

This is a grammar check, I'm not sure why we abandon this before.
@shenli PTAL

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 15, 2017

Contributor

PTAL @coocood

Contributor

XuHuaiyu commented Sep 15, 2017

PTAL @coocood

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 18, 2017

Member

LGTM

Member

hanfei1991 commented Sep 18, 2017

LGTM

@coocood

LGTM

@hanfei1991 hanfei1991 merged commit d38135d into master Sep 18, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the xhy/agg branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment