New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: only cast values for modified columns in update statement #4517

Merged
merged 5 commits into from Sep 14, 2017

Conversation

Projects
None yet
4 participants
@breeswish
Member

breeswish commented Sep 13, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 13, 2017

Contributor

LGTM

Contributor

XuHuaiyu commented Sep 13, 2017

LGTM

@winkyao

LGTM

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao

winkyao Sep 13, 2017

Member

/run-all-test

Member

winkyao commented Sep 13, 2017

/run-all-test

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 13, 2017

Member

This is a data race in goleveldb which is fixed by
syndtr/goleveldb@e5ce663#diff-2f76daf2fb4a517abdbea03f2e025a0a

Member

coocood commented Sep 13, 2017

This is a data race in goleveldb which is fixed by
syndtr/goleveldb@e5ce663#diff-2f76daf2fb4a517abdbea03f2e025a0a

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 14, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Sep 14, 2017

/run-all-test

@coocood coocood added status/LGT2 and removed status/LGT1 labels Sep 14, 2017

@XuHuaiyu XuHuaiyu merged commit fc8b2ee into master Sep 14, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the wenxuan/issue-4514 branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment