New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, plan: abandon the selection controller #4528

Merged
merged 4 commits into from Sep 21, 2017

Conversation

Projects
None yet
4 participants
@hanfei1991
Member

hanfei1991 commented Sep 14, 2017

selection controller is a optimization for old plan.
fix #4526

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Sep 14, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 14, 2017

Member

/run-all-tests

Member

hanfei1991 commented Sep 14, 2017

/run-all-tests

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 15, 2017

Member

Can we not skip the two tests?

Member

coocood commented Sep 15, 2017

Can we not skip the two tests?

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 15, 2017

Member

@hanfei1991
Is it hard to move the two tests to new plan in this PR?

Member

coocood commented Sep 15, 2017

@hanfei1991
Is it hard to move the two tests to new plan in this PR?

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 15, 2017

Member

@coocood Moving test will take huge effort.

Member

hanfei1991 commented Sep 15, 2017

@coocood Moving test will take huge effort.

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 18, 2017

Member

@winkyao which one should be fixed ?

Member

hanfei1991 commented Sep 18, 2017

@winkyao which one should be fixed ?

@winoros winoros added the status/LGT1 label Sep 18, 2017

@coocood

LGTM

@hanfei1991 hanfei1991 merged commit 67fa005 into master Sep 21, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.419%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the hanfei/panic branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment