New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: change FMSketch hash function from fnv to murmur #4541

Merged
merged 2 commits into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@lamxTyler
Member

lamxTyler commented Sep 15, 2017

It seems that FNV is not a good hash function for FMSketch, for example, it will hash all encoded, greater than 0, int value to an odd value. From this post it seems that murmur hash is a good choice.
PTAL @coocood @hanfei1991 @winoros

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 15, 2017

Member

LGTM

Member

coocood commented Sep 15, 2017

LGTM

@coocood coocood merged commit a7bcc2b into master Sep 15, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lamxTyler lamxTyler deleted the xhb/mur branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment