New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove the usage of "TypeClass" in "builtin_op.go" #4547

Merged
merged 6 commits into from Sep 18, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Sep 18, 2017

to #4394

@XuHuaiyu XuHuaiyu changed the title from expression: remove the useage of "TypeClass" in "builtin_op.go" to expression: remove the usage of "TypeClass" in "builtin_op.go" Sep 18, 2017

@@ -339,13 +339,16 @@ func (c *isTrueOrFalseFunctionClass) getFunction(ctx context.Context, args []Exp
return nil, errors.Trace(err)
}
argTp := tpInt

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Sep 18, 2017

Contributor

this is an equivalent replacement?
should we keep it here, and use fieldTp2EvalTp in line 343?

@XuHuaiyu

XuHuaiyu Sep 18, 2017

Contributor

this is an equivalent replacement?
should we keep it here, and use fieldTp2EvalTp in line 343?

This comment has been minimized.

@zz-jason

zz-jason Sep 18, 2017

Member

yes, ClassReal == tpReal and ClassDecimal == tpDecimal

@zz-jason

zz-jason Sep 18, 2017

Member

yes, ClassReal == tpReal and ClassDecimal == tpDecimal

zz-jason added some commits Sep 18, 2017

zz-jason added some commits Sep 18, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 18, 2017

Member

LGTM

Member

coocood commented Sep 18, 2017

LGTM

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 18, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Sep 18, 2017

/run-all-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Sep 18, 2017

@XuHuaiyu PTAL

@XuHuaiyu

LGTM

@XuHuaiyu XuHuaiyu merged commit ae00bc2 into master Sep 18, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the zz-jason/remove/typeclass/expression/builtin_op branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment