New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove the usage of "TypeClass" in "builtin_math.go" #4568

Merged
merged 9 commits into from Sep 21, 2017

Conversation

Projects
None yet
4 participants
@zz-jason
Member

zz-jason commented Sep 19, 2017

to #4394

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 20, 2017

Member

/run-all-test

Member

zz-jason commented Sep 20, 2017

/run-all-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 20, 2017

Member

/run-unit-test

Member

zz-jason commented Sep 20, 2017

/run-unit-test

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Sep 20, 2017

Member

LGTM

Member

ngaut commented Sep 20, 2017

LGTM

@ngaut ngaut added status/LGT2 and removed status/LGT1 labels Sep 20, 2017

@coocood coocood merged commit dba31ef into master Sep 21, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.753%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the zz-jason/remove/typeclass/expression/builtin_math branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment