New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove the usage of "TypeClass" in "builtin_cast.go" #4570

Merged
merged 6 commits into from Sep 20, 2017

Conversation

Projects
None yet
4 participants
@zz-jason
Member

zz-jason commented Sep 19, 2017

to #4394

sig = &builtinCastStringAsIntSig{bf}
sig.setPbCode(tipb.ScalarFuncSig_CastStringAsInt)
default:
panic("unsupported evalTp in castAsIntFunctionClass")

This comment has been minimized.

@zimulala

zimulala Sep 20, 2017

Member

Return an error is better.

@zimulala

zimulala Sep 20, 2017

Member

Return an error is better.

This comment has been minimized.

@zz-jason

zz-jason Sep 20, 2017

Member

no, we can discover programmer's mistake through this panic.

@zz-jason

zz-jason Sep 20, 2017

Member

no, we can discover programmer's mistake through this panic.

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Sep 20, 2017

Member

LGTM

Member

zimulala commented Sep 20, 2017

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Sep 20, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 20, 2017

Member

do not merge now, wait for #4543

Member

zz-jason commented Sep 20, 2017

do not merge now, wait for #4543

@zz-jason zz-jason removed the status/DNM label Sep 20, 2017

@ngaut ngaut merged commit 71c7470 into master Sep 20, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.809%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@ngaut ngaut deleted the zz-jason/remove/typeclass/expression/builtin_cast branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment