New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove the usage of "TypeClass" in "builtin_string.go" #4573

Merged
merged 4 commits into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Copy link
Member

zz-jason commented Sep 19, 2017

to #4394

@XuHuaiyu
Copy link
Contributor

XuHuaiyu left a comment

rest LGTM

case types.ClassString:
argTp := fieldTp2EvalTp(args[0].GetType())
switch argTp {
case tpString, tpDatetime, tpTimestamp, tpDuration, tpJSON:

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Sep 20, 2017

Contributor

do we need a function like IsStringEvalTp

This comment has been minimized.

@zz-jason

zz-jason Sep 21, 2017

Member

no need for now

@coocood
Copy link
Member

coocood left a comment

LGTM

@coocood coocood merged commit d089deb into master Sep 21, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.802%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the zz-jason/remove/typeclass/expression/builtin_string branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment