New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove the usage of "TypeClass" in "builtin_arithmetic.go" #4575

Merged
merged 8 commits into from Sep 22, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Sep 19, 2017

to #4394

if ft.ToClass() == types.ClassString {
return types.ClassReal
evalTp4Ft := fieldTp2EvalTp(ft)
if evalTp4Ft != tpDecimal && evalTp4Ft != tpInt {

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Sep 20, 2017

Contributor

add a comment for this check

@XuHuaiyu

XuHuaiyu Sep 20, 2017

Contributor

add a comment for this check

zz-jason added some commits Sep 20, 2017

Merge branch 'master' of https://github.com/pingcap/tidb into zz-jaso…
…n/remove/typeclass/expression/builtin_arithmetic
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 22, 2017

Contributor

LGTM

Contributor

XuHuaiyu commented Sep 22, 2017

LGTM

@coocood

LGTM

@zz-jason zz-jason merged commit bd01434 into master Sep 22, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.369%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason/remove/typeclass/expression/builtin_arithmetic branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment