New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix length of all show stmt #4589

Merged
merged 5 commits into from Sep 22, 2017

Conversation

Projects
None yet
3 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Sep 20, 2017

further improve #4544
PTAL @shenli @winkyao @coocood

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 20, 2017

Member

LGTM
Good job!

Member

shenli commented Sep 20, 2017

LGTM
Good job!

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 20, 2017

Member

@XuHuaiyu
ColumnInfo will be written to the client after the first time of Next, so we need to do it in first call of Next.
See:
https://github.com/pingcap/tidb/blob/master/server/conn.go#L781
https://github.com/pingcap/tidb/blob/master/server/conn.go#L798

Member

coocood commented Sep 20, 2017

@XuHuaiyu
ColumnInfo will be written to the client after the first time of Next, so we need to do it in first call of Next.
See:
https://github.com/pingcap/tidb/blob/master/server/conn.go#L781
https://github.com/pingcap/tidb/blob/master/server/conn.go#L798

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 20, 2017

Member

@XuHuaiyu Please fix ci.

Member

shenli commented Sep 20, 2017

@XuHuaiyu Please fix ci.

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 22, 2017

Contributor

PTAL @coocood

Contributor

XuHuaiyu commented Sep 22, 2017

PTAL @coocood

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 22, 2017

Member

CI failed.

Member

coocood commented Sep 22, 2017

CI failed.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 22, 2017

Member

LGTM

Member

coocood commented Sep 22, 2017

LGTM

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 22, 2017

Member

/run-common-test

Member

coocood commented Sep 22, 2017

/run-common-test

@XuHuaiyu XuHuaiyu added status/LGT2 and removed status/LGT1 labels Sep 22, 2017

@XuHuaiyu XuHuaiyu merged commit 83aeca4 into master Sep 22, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.34%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the xhy/show branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment