New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: open new expression framework by default #4595

Merged
merged 11 commits into from Sep 22, 2017

Conversation

Projects
None yet
4 participants
@zz-jason
Member

zz-jason commented Sep 21, 2017

No description provided.

@zz-jason zz-jason added the status/WIP label Sep 21, 2017

zz-jason added some commits Sep 21, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 21, 2017

Member

/run-all-test

Member

zz-jason commented Sep 21, 2017

/run-all-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 21, 2017

Member

/run-unit-test

Member

zz-jason commented Sep 21, 2017

/run-unit-test

@zz-jason zz-jason removed the status/WIP label Sep 21, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 22, 2017

Member

/run-all-test

Member

zz-jason commented Sep 22, 2017

/run-all-test

Show outdated Hide outdated expression/builtin.go
Show outdated Hide outdated expression/builtin_compare.go

zz-jason added some commits Sep 22, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 22, 2017

Contributor

LGTM

Contributor

XuHuaiyu commented Sep 22, 2017

LGTM

case tpJSON:
res, isNull, err = b.self.evalJSON(row)
case tpString:
res, isNull, err = b.self.evalString(row)

This comment has been minimized.

@winkyao

winkyao Sep 22, 2017

Member

default?

@winkyao

winkyao Sep 22, 2017

Member

default?

This comment has been minimized.

@zz-jason

zz-jason Sep 22, 2017

Member

Yes, mainly copied from ScalarFunction.Eval(). This function now only used in unit tests, we should remove this API in the future.

@zz-jason

zz-jason Sep 22, 2017

Member

Yes, mainly copied from ScalarFunction.Eval(). This function now only used in unit tests, we should remove this API in the future.

@winkyao

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Sep 22, 2017

@coocood coocood merged commit 069cc8b into master Sep 22, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.498%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the zz-jason/expression/framework branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment