New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Refactor aggregation #4605

Merged
merged 12 commits into from Sep 22, 2017

Conversation

Projects
None yet
6 participants
@wangyisong1996
Contributor

wangyisong1996 commented Sep 22, 2017

Aggregation results were stored in aggregation functions, so one map is created for each function to store different groups’ results, which requires much memory.
The aggregation functions are refactored and are now stateless, and the maps are kept in executor (executor.HashAggExec and mocktikv.aggregateExec) so that only one map is needed to store all the functions’ results, which reduced the memory usage.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Sep 22, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Sep 22, 2017

CLA assistant check
All committers have signed the CLA.

@wangyisong1996

This comment has been minimized.

Show comment
Hide comment
@wangyisong1996
Contributor

wangyisong1996 commented Sep 22, 2017

Show outdated Hide outdated executor/aggregate.go
Show outdated Hide outdated expression/aggregation/avg.go
@wangyisong1996

This comment has been minimized.

Show comment
Hide comment
@wangyisong1996
Contributor

wangyisong1996 commented Sep 22, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 22, 2017

Member

/run-all-tests

Member

hanfei1991 commented Sep 22, 2017

/run-all-tests

coocood and others added some commits Sep 22, 2017

@hanfei1991

LGTM

@hanfei1991 hanfei1991 merged commit 25b5a2c into master Sep 22, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
coverage/coveralls First build on master at 72.683%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the wys/agg_refactor branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment