New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove expression/typeinfer.go entirely #4611

merged 3 commits into from Sep 22, 2017


None yet
4 participants

XuHuaiyu commented Sep 22, 2017

This commit does 2 things:

  1. remove expression/typeinfer.go entirely,
    all the type inferring work will be done in expression-rewrite phrase

  2. remove the validator of sql like 'insert into t set a = 1, b = a'
    which seems to be unreasonable but supported by MySQL.
    Before this commit, validator will throw an error like ERROR 1054 (42S22): Unknown column '' in 'field list',
    after this commit, validator will work successfully, but the executor will cause a panic when executing this sql which will be fixed in #4603 .
    PTAL @coocood @hanfei1991 @zz-jason

*: 1. remove expression/typeinfer.go entirely
2. remove the validator of sql like 'insert into t set a = 1, b = a'

This comment has been minimized.

Show comment
Hide comment

hanfei1991 Sep 22, 2017




hanfei1991 commented Sep 22, 2017


@hanfei1991 hanfei1991 added status/LGT2 and removed status/LGT1 labels Sep 22, 2017

@coocood coocood merged commit d2d14d8 into master Sep 22, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
ci/circleci Your tests passed on CircleCI!
jenkins-ci-tidb/build Jenkins job succeeded.
license/cla Contributor License Agreement is signed.

@coocood coocood deleted the xhy/typeinfer branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment