New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SQLMode ONLY_FULL_GROUP_BY and fix a join panic bug #4613

Merged
merged 90 commits into from Nov 6, 2017

Conversation

Projects
None yet
9 participants
@CodeRushing
Contributor

CodeRushing commented Sep 24, 2017

Add ONLY_FULL_GROUP_BY to default sql_mode, and support this sql_mode.

Fix the bug that in buildJoin plan, if rightPlan is nil when buildResultSetNode of join.Right meets error, panic would occur.

CodeRushing and others added some commits Aug 30, 2017

executor: fix when update ignore of primary key conflicts, the old re…
…cord which meets the where condition is removed, but the new record still exists for conflicting
Show outdated Hide outdated plan/logical_plan_builder.go
Show outdated Hide outdated plan/logical_plan_builder.go

CodeRushing added some commits Nov 1, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 4, 2017

Member

LGTM

Well done!

Member

coocood commented Nov 4, 2017

LGTM

Well done!

@coocood

coocood approved these changes Nov 4, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 4, 2017

Member

/run-all-test

Member

coocood commented Nov 4, 2017

/run-all-test

@CodeRushing

This comment has been minimized.

Show comment
Hide comment
@CodeRushing

CodeRushing Nov 6, 2017

Contributor

@coocood I make race test in my local computer and it's ok.

Contributor

CodeRushing commented Nov 6, 2017

@coocood I make race test in my local computer and it's ok.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 6, 2017

Member

@CodeRushing
OK, the test failure is not related to this PR.

Member

coocood commented Nov 6, 2017

@CodeRushing
OK, the test failure is not related to this PR.

@coocood coocood merged commit b7c722a into pingcap:master Nov 6, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu referenced this pull request Nov 6, 2017

Merged

*: remove resolver.go #4988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment