New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: add limitation for index comment #4619

Merged
merged 4 commits into from Sep 26, 2017

Conversation

Projects
None yet
3 participants
@jackysp
Member

jackysp commented Sep 25, 2017

Fix issue #4618. @zimulala PTAL

Show outdated Hide outdated parser/parser.y
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 25, 2017

Member

In MySQL this is not a syntax error.

Member

shenli commented Sep 25, 2017

In MySQL this is not a syntax error.

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Sep 25, 2017

Member

Use MySQL style to deal with this error. PTAL @shenli

Member

jackysp commented Sep 25, 2017

Use MySQL style to deal with this error. PTAL @shenli

@jackysp jackysp changed the title from parser: add limitation for index comment to ddl: add limitation for index comment Sep 25, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 25, 2017

Member

LGTM

Member

coocood commented Sep 25, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 25, 2017

Member

LGTM

Member

shenli commented Sep 25, 2017

LGTM

@shenli

shenli approved these changes Sep 25, 2017

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Sep 26, 2017

Member

/run-all-test

Member

jackysp commented Sep 26, 2017

/run-all-test

@jackysp jackysp added the status/DNM label Sep 26, 2017

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Sep 26, 2017

Member

CI failed, please wait.

Member

jackysp commented Sep 26, 2017

CI failed, please wait.

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Sep 26, 2017

Member

/run-all-test

Member

jackysp commented Sep 26, 2017

/run-all-test

@coocood coocood merged commit c1d1ddc into master Sep 26, 2017

9 of 11 checks passed

jenkins-ci-tidb/mybatis-test Jenkins job failed
Details
jenkins-ci-tidb/unit-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.673%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the yusp/issue4618 branch Sep 26, 2017

hanfei1991 added a commit that referenced this pull request Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment