New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, types: remove the useage of "evalExprToXXX" functions #4666

Merged
merged 4 commits into from Sep 27, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Sep 27, 2017

fix #4405

before this pr:

BenchmarkEvalInt-8              50000000                28.9 ns/op             0 B/op          0 allocs/op
BenchmarkEvalReal-8             50000000                30.5 ns/op             0 B/op          0 allocs/op
BenchmarkEvalString-8           50000000                34.6 ns/op             0 B/op          0 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      4.825s

after this pr:

BenchmarkEvalInt-8              200000000                6.40 ns/op            0 B/op          0 allocs/op
BenchmarkEvalReal-8             200000000                6.72 ns/op            0 B/op          0 allocs/op
BenchmarkEvalString-8           100000000               15.3 ns/op             0 B/op          0 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      5.554s
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 27, 2017

Member

/run-all-test

Member

zz-jason commented Sep 27, 2017

/run-all-test

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 27, 2017

Member

Impressive!

Member

shenli commented Sep 27, 2017

Impressive!

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Sep 27, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 27, 2017

Member

LGTM

Member

coocood commented Sep 27, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 27, 2017

Member

LGTM

Member

shenli commented Sep 27, 2017

LGTM

@shenli

shenli approved these changes Sep 27, 2017

@shenli shenli merged commit 1c4143e into master Sep 27, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.638%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@shenli shenli deleted the zz-jason/expression/4405 branch Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment