New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make prepare stmt retriable when schema is out-dated. #4669

Merged
merged 3 commits into from Sep 28, 2017

Conversation

Projects
None yet
5 participants
@hanfei1991
Member

hanfei1991 commented Sep 27, 2017

We should use ast node to try instead of raw stmt. Because execute stmt will change its original text for printing log, it's unreasonable !

Show outdated Hide outdated plan/optimizer.go
Show outdated Hide outdated plan/optimizer.go
@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991
Member

hanfei1991 commented Sep 27, 2017

@shenli PTAL

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 27, 2017

Member

LGTM
@coocood PTAL

Member

shenli commented Sep 27, 2017

LGTM
@coocood PTAL

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Sep 27, 2017

Contributor

"execute stmt will change its original text for printing log"

That's not true!

Contributor

tiancaiamao commented Sep 27, 2017

"execute stmt will change its original text for printing log"

That's not true!

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Sep 27, 2017

Contributor

LGTM @coocood

Contributor

tiancaiamao commented Sep 27, 2017

LGTM @coocood

Show outdated Hide outdated executor/adapter.go
Show outdated Hide outdated ast/ast.go

hanfei1991 and others added some commits Sep 28, 2017

@zz-jason

LGTM

@hanfei1991 hanfei1991 merged commit 3dfbf52 into master Sep 28, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the hanfei/prepare-retry branch Sep 28, 2017

tiancaiamao added a commit that referenced this pull request Sep 28, 2017

hanfei1991 added a commit that referenced this pull request Sep 28, 2017

*: revert 4669 "make prepare stmt retriable when schema is out-dated" (
…#4676)

* Revert "executor: analyze use NewSelectResult (#4667)"

This reverts commit d1d78b7.

* Revert "table: Speed up the add index operation (#4632)"

This reverts commit d782ce1.

* Revert "*: make prepare stmt retriable when schema is out-dated. (#4669)"

This reverts commit 3dfbf52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment