New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: prepare to enforce errcheck, part1 #4670

Merged
merged 8 commits into from Sep 30, 2017

Conversation

Projects
None yet
3 participants
@coocood
Member

coocood commented Sep 28, 2017

See #4668

coocood added some commits Sep 27, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood
Member

coocood commented Sep 28, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 29, 2017

Member

/run-all-tests

Member

shenli commented Sep 29, 2017

/run-all-tests

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood
Member

coocood commented Sep 30, 2017

@shenli PTAL

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 30, 2017

Member

LGTM

Member

zz-jason commented Sep 30, 2017

LGTM

zz-jason and others added some commits Sep 30, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 30, 2017

Member

LGTM

Member

shenli commented Sep 30, 2017

LGTM

@shenli

shenli approved these changes Sep 30, 2017

@coocood coocood merged commit eb8df35 into master Sep 30, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood/errcheck branch Sep 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment