New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove useless code #4672

Merged
merged 5 commits into from Sep 28, 2017

Conversation

Projects
None yet
5 participants
@zz-jason
Member

zz-jason commented Sep 28, 2017

No description provided.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 28, 2017

Member

/run-all-tests

Member

shenli commented Sep 28, 2017

/run-all-tests

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Sep 28, 2017

Member

LGTM

Member

ngaut commented Sep 28, 2017

LGTM

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 28, 2017

Member

It seems argValues can also be removed.

Member

hanfei1991 commented Sep 28, 2017

It seems argValues can also be removed.

@zz-jason zz-jason changed the title from expression: remove function "evalArgs()" to expression: remove useless code Sep 28, 2017

zz-jason added some commits Sep 28, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 28, 2017

Member

LGTM

Member

hanfei1991 commented Sep 28, 2017

LGTM

@hanfei1991

LGTM

@hanfei1991 hanfei1991 merged commit 459c469 into master Sep 28, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the zz-jason/expression/evalArgs branch Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment