New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: change like function's behavior. #4683

Merged
merged 3 commits into from Sep 29, 2017

Conversation

Projects
None yet
4 participants
@winoros
Member

winoros commented Sep 28, 2017

Currently, tikv's like function is case sensitive. To keep compatible with it, change tidb's like to case sensitive too.
PTAL @coocood @winkyao @hanfei1991

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 28, 2017

Member

LGTM

Member

shenli commented Sep 28, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 28, 2017

Member

/run-all-tests

Member

shenli commented Sep 28, 2017

/run-all-tests

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 28, 2017

Member

/run-common-test

Member

shenli commented Sep 28, 2017

/run-common-test

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 28, 2017

Member

/run-unit-test

Member

shenli commented Sep 28, 2017

/run-unit-test

@jackysp

LGTM

@hanfei1991 hanfei1991 merged commit 56ed7f1 into master Sep 29, 2017

7 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.711%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the yiding/like branch Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment