New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support SyncLog kv request option #4689

Merged
merged 11 commits into from Sep 30, 2017

Conversation

Projects
None yet
3 participants
@tiancaiamao
Contributor

tiancaiamao commented Sep 29, 2017

Add a new kv request option supported by TiKV: syncLog decides whether the WAL(write-ahead log) of this request should be synchronized (to disk). Currently only meta request set this option.

tiancaiamao added some commits Sep 27, 2017

*: support NotFillCache kv request option
If TiDB send a request with NotFillCache option, the LRU cache of underlying
storage will not be touched. select statement with SQL_NO_CACHE will use it.
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Sep 30, 2017

LGTM
@disksing @coocood PTAL

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 30, 2017

Member

/run-all-tests

Member

shenli commented Sep 30, 2017

/run-all-tests

@disksing

LGTM.

@@ -1957,12 +1957,14 @@ const (
checkRequestOff = 0
checkRequestPriority = 1
checkRequestNotFillCache = 2
checkRequestSyncLog = 3

This comment has been minimized.

@disksing

disksing Sep 30, 2017

Member

you can use iota

@disksing

disksing Sep 30, 2017

Member

you can use iota

@tiancaiamao tiancaiamao merged commit e6360b1 into master Sep 30, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.719%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao/sync-log branch Sep 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment