New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite unit test for Minus and Plus #4691

Merged
merged 4 commits into from Sep 30, 2017

Conversation

Projects
None yet
5 participants
@zz-jason
Member

zz-jason commented Sep 29, 2017

to #4690

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 29, 2017

Member

LGTM

Member

shenli commented Sep 29, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 29, 2017

Member

/run-all-tests

Member

shenli commented Sep 29, 2017

/run-all-tests

@winkyao

LGTM

@coocood coocood merged commit 3f4bdf6 into master Sep 30, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the zz-jason/expression/rewritetest/builtin_arighmetic branch Sep 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment