New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql,ddl: fix #4684, unsigned integer column length is not consistent with MySQL #4693

Merged
merged 12 commits into from Oct 9, 2017

Conversation

Projects
None yet
5 participants
@winkyao
Member

winkyao commented Sep 29, 2017

fix #4684
fix #3725

winkyao added some commits Sep 29, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Sep 29, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Sep 30, 2017

@coocood PTAL

winkyao and others added some commits Sep 30, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 30, 2017

Member

LGTM

Member

shenli commented Sep 30, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 30, 2017

Member

/run-all-tests

Member

shenli commented Sep 30, 2017

/run-all-tests

@@ -904,7 +904,7 @@ func (s *testColumnSuite) TestModifyColumn(c *C) {
err error
}{
{"int", "bigint", nil},
{"int", "int unsigned", errUnsupportedModifyColumn.GenByArgs("unsigned true not match origin false")},
{"int", "int unsigned", errUnsupportedModifyColumn.GenByArgs("length 10 is less than origin 11")},

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Oct 9, 2017

Contributor

this error message is consistent with MySQL?

@XuHuaiyu

XuHuaiyu Oct 9, 2017

Contributor

this error message is consistent with MySQL?

This comment has been minimized.

@winkyao

winkyao Oct 9, 2017

Member

no, the error is only returned by TiDB because we not support this ddl request yet. @XuHuaiyu

@winkyao

winkyao Oct 9, 2017

Member

no, the error is only returned by TiDB because we not support this ddl request yet. @XuHuaiyu

Show outdated Hide outdated ddl/ddl_api.go

@zz-jason zz-jason added the status/LGT1 label Oct 9, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 9, 2017

Member

@winkyao Please address the comment.

Member

shenli commented Oct 9, 2017

@winkyao Please address the comment.

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 9, 2017

Contributor

LGTM

Contributor

XuHuaiyu commented Oct 9, 2017

LGTM

@winkyao winkyao added status/LGT2 and removed status/LGT1 labels Oct 9, 2017

@coocood coocood merged commit 64b5bc8 into master Oct 9, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the winkyao/fix_issue_4684 branch Oct 9, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment