New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Avoid type assert for ast.ExprNode #4710

Merged
merged 2 commits into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@shenli
Member

shenli commented Oct 4, 2017

Remove most of the type assertions for ast.ExprNode.

For issue #4709

@shenli shenli referenced this pull request Oct 4, 2017

Open

Avoid type assertion in parser.y #4709

0 of 2 tasks complete
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 4, 2017

Member

/run-all-tests

Member

shenli commented Oct 4, 2017

/run-all-tests

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 9, 2017

Member

LGTM

Member

zz-jason commented Oct 9, 2017

LGTM

1 similar comment
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 9, 2017

Member

LGTM

Member

coocood commented Oct 9, 2017

LGTM

@coocood

coocood approved these changes Oct 9, 2017

@zz-jason zz-jason added the status/LGT2 label Oct 9, 2017

@coocood coocood merged commit a3ce471 into master Oct 9, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the shenli/parser-expr branch Oct 9, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment