New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv/mocktikv: rpc handler should put error in response instead of return it #4723

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@tiancaiamao
Contributor

tiancaiamao commented Oct 9, 2017

Locked error should be put into tikvrpc.Response, if it's returned as an error, region request sender will drop region cache mistakenly, and make further request all fail.
This will fix CI in #4699
@hanfei1991

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Oct 9, 2017

Member

LGTM

Member

hanfei1991 commented Oct 9, 2017

LGTM

@coocood

coocood approved these changes Oct 9, 2017

LGTM

@coocood coocood merged commit 856aa41 into master Oct 9, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the tiancaiamao/mocktikv-response branch Oct 9, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment