New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: enforce errcheck in Makefile #4724

Merged
merged 4 commits into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@coocood
Member

coocood commented Oct 9, 2017

checks all errors and enable errcheck in Makefile

Fixes #4668

coocood added some commits Oct 9, 2017

*: enforce errcheck in Makefile
checks all errors and enable errcheck in Makefile

Fixes #4668
Show outdated Hide outdated expression/util.go
Show outdated Hide outdated expression/util.go
@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Oct 9, 2017

Contributor

LGTM

Contributor

tiancaiamao commented Oct 9, 2017

LGTM

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood
Member

coocood commented Oct 9, 2017

@shenli PTAL

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 9, 2017

Member

LGTM

Member

shenli commented Oct 9, 2017

LGTM

@shenli

shenli approved these changes Oct 9, 2017

@coocood coocood merged commit 9c2ea17 into master Oct 9, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood/errcheck branch Oct 9, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Oct 10, 2017

*: enforce errcheck in Makefile (#4724)
checks all errors and enable errcheck in Makefile

Fixes pingcap#4668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment