New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: set proper parent for newly projection-eliminated child #4730

Merged
merged 2 commits into from Oct 10, 2017

Conversation

Projects
None yet
4 participants
@zz-jason
Member

zz-jason commented Oct 10, 2017

fix the error in tidb.log:

2017/10/10 10:42:37.755 terror.go:342: [error] /Users/jianzhang.zj/opt/gopath/src/github.com/pingcap/tidb/plan/plan.go:519: [plan:2]ReplaceParent Failed!
/Users/jianzhang.zj/opt/gopath/src/github.com/pingcap/tidb/plan/logical_plans.go:446:
@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Oct 10, 2017

Member

LGTM

Member

hanfei1991 commented Oct 10, 2017

LGTM

@winoros winoros added the status/LGT2 label Oct 10, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 10, 2017

Member

LGTM

Member

coocood commented Oct 10, 2017

LGTM

@hanfei1991 hanfei1991 merged commit a8db31d into master Oct 10, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the zz-jason/plan/eliminate branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment