New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege/privileges: fix show grants display empty entries #4734

Merged
merged 2 commits into from Oct 11, 2017

Conversation

Projects
None yet
4 participants
@tiancaiamao
Contributor

tiancaiamao commented Oct 10, 2017

If we revoke after grant some privilege, show grants display some wrong results:

GRANT ALL PRIVILEGES ON `te%`.* TO 'show'@'localhost'
REVOKE ALL PRIVILEGES ON `te%`.* FROM 'show'@'localhost'
SHOW GRANTS FOR 'show'@'localhost'

should get nothing, but get

GRANT ON `te%`.* TO 'show'@'localhost'
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 11, 2017

Member

LGTM

Member

shenli commented Oct 11, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 11, 2017

Member

/run-all-tests

Member

shenli commented Oct 11, 2017

/run-all-tests

@zz-jason

LGTM

@coocood coocood merged commit 2eab78f into master Oct 11, 2017

6 of 10 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
jenkins-ci-tidb/integration-common-test Jenkins job is running.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job is running.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job is running.
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the tiancaiamao/show-grants-display branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment