New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: use single method to set parent and children. #4738

Merged
merged 2 commits into from Oct 10, 2017

Conversation

Projects
None yet
3 participants
@coocood
Member

coocood commented Oct 10, 2017

Fix a few places where parents is not set properly.
and reduce the risk to forget to set parents in the future.
Physical plan is not handled since they don't need to set parents.

plan: use single method to set parent and children.
Fix a few places where parents is not set properly.
and reduce the risk to forget to set parents in the future.
Physical plan is not handled since they don't need to set parents.
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood
Member

coocood commented Oct 10, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 10, 2017

Member

/run-all-test

Member

zz-jason commented Oct 10, 2017

/run-all-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 10, 2017

Member

LGTM

Member

zz-jason commented Oct 10, 2017

LGTM

@winoros

LGTM

@winoros winoros added the status/LGT2 label Oct 10, 2017

@coocood coocood merged commit b1a3244 into master Oct 10, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood/set-parent-children branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment