New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix ineffectual assignments #4713 #4746

Merged
merged 5 commits into from Oct 12, 2017

Conversation

Projects
None yet
4 participants
@mccxj
Contributor

mccxj commented Oct 11, 2017

See #4713.

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Oct 11, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Oct 11, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

Show outdated Hide outdated expression/builtin_math.go
Show outdated Hide outdated expression/builtin_math.go
Show outdated Hide outdated plan/logical_plan_test.go
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 11, 2017

Contributor

PTAL @coocood

Contributor

XuHuaiyu commented Oct 11, 2017

PTAL @coocood

@mccxj

This comment has been minimized.

Show comment
Hide comment
@mccxj

mccxj Oct 11, 2017

Contributor
Contributor

mccxj commented Oct 11, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 11, 2017

Member

LGTM

Member

coocood commented Oct 11, 2017

LGTM

@XuHuaiyu

LGTM

@XuHuaiyu XuHuaiyu merged commit 51a6e6f into pingcap:master Oct 12, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.605%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@mccxj mccxj deleted the mccxj:goreportcard-ineffassign branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment