GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If the DDL job state is done or synced, we can't cancel this job.
*: support cancel the DDL job
Merge branch 'master' into zimuxia/cancel-ddl
*: change the job state
ddl: support for cancelling job and add tests
*: add details of the failure information
inspectkv: tiny update
@coocood @winkyao PTAL
inspectkv may not be a proper package for this function.
Other functions that handle jobs are placed in this package, so I put it here.
inspectkv: address comments
*: address comments
@coocood We will rollback if the error is ErrKeyExists. It's the old logical.
Why not do this in CancelDDLJobsExec.Next()?
It seems CancelDDLJobsExec.Next() has no txn.
We can new a txn and commit this txn in CancelDDLJobsExec.Next(). But this solution will commit the previous transaction.
ddl: address comments
PTAL @coocood @winkyao @shenli
ddl: add tests and add clean up channel
ddl: tiny update
Merge remote-tracking branch 'origin/master' into zimuxia/cancel-ddl
*: Support the operation of `cancel DDL jobs` (pingcap#4753)
* *: support cancel the DDL job
*: Support the operation of `cancel DDL jobs` (#4753) (#4930)