New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: some builtin functions can be folded #4756

Merged
merged 6 commits into from Oct 12, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Oct 12, 2017

  • sysdate
  • curdate
  • current_date
  • utc_date
  • utc_timestamp
  • unix_timestamp
  • database
  • current_user
  • user
  • connection_id
  • last_insert_id
  • version
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 12, 2017

Member

What about utc_date, curdate, etc?

Member

coocood commented Oct 12, 2017

What about utc_date, curdate, etc?

@zz-jason zz-jason changed the title from expression: unix_timestamp, utc_timestamp can be folded to expression: some builtin functions can be folded Oct 12, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 12, 2017

Member

/run-all-test

Member

zz-jason commented Oct 12, 2017

/run-all-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Oct 12, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 12, 2017

Contributor

LGTM

Contributor

XuHuaiyu commented Oct 12, 2017

LGTM

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 12, 2017

Member

LGTM

Member

coocood commented Oct 12, 2017

LGTM

@coocood coocood merged commit e488bcc into master Oct 12, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.511%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the zz-jason/expression/foldable branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment