New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix bug when build histograms for columns #4757

Merged
merged 2 commits into from Oct 12, 2017

Conversation

Projects
None yet
3 participants
@lamxTyler
Member

lamxTyler commented Oct 12, 2017

Sometimes the NDV calculated from FM Sketch may larger than row count, which will make the ndvFactor less than 1, and the Repeats less than 1.

lamxTyler and others added some commits Oct 12, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 12, 2017

Member

LGTM

Member

zz-jason commented Oct 12, 2017

LGTM

@winoros

LGTM

@lamxTyler lamxTyler merged commit a5266d6 into master Oct 12, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.528%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lamxTyler lamxTyler deleted the xhb/fix branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment