New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, plan: remove "foldable" from "baseBuiltinFunc" #4759

Merged
merged 4 commits into from Oct 12, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Oct 12, 2017

No description provided.

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 12, 2017

Member

/run-all-test

Member

zz-jason commented Oct 12, 2017

/run-all-test

@coocood coocood changed the title from expression, plan: remove "cacheable" from "baseBuiltinFunc" to expression, plan: remove "foldable" from "baseBuiltinFunc" Oct 12, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Oct 12, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 12, 2017

Member

LGTM

Member

coocood commented Oct 12, 2017

LGTM

@breeswish

This comment has been minimized.

Show comment
Hide comment
@breeswish

breeswish Oct 12, 2017

Member

LGTM

Member

breeswish commented Oct 12, 2017

LGTM

@breeswish breeswish merged commit 6062691 into master Oct 12, 2017

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.531%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@breeswish breeswish deleted the zz-jason/expression/foldable branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment