New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: fix bug about copy function. #4765

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@hanfei1991
Member

hanfei1991 commented Oct 13, 2017

When we copy a plan, we should also copy its expected count.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 13, 2017

Member

LGTM

Member

coocood commented Oct 13, 2017

LGTM

@lamxTyler

LGTM

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros

winoros Oct 13, 2017

Member

Keep expectedCnt in basePhysicalPlan and change the newBasePhysicalPlan() is better?
@coocood @hanfei1991

Member

winoros commented Oct 13, 2017

Keep expectedCnt in basePhysicalPlan and change the newBasePhysicalPlan() is better?
@coocood @hanfei1991

@hanfei1991 hanfei1991 merged commit 2efa9ba into master Oct 13, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.545%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the hanfei/copy branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment