New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove "self" field in "baseBuiltinFunc" completely #4766

Merged
merged 3 commits into from Oct 13, 2017

Conversation

Projects
None yet
5 participants
@zz-jason
Member

zz-jason commented Oct 13, 2017

No description provided.

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Oct 13, 2017

@coocood PTAL

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 13, 2017

Contributor

LGTM

Contributor

XuHuaiyu commented Oct 13, 2017

LGTM

Show outdated Hide outdated expression/builtin_test.go Outdated
@coocood

LGTM

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 13, 2017

Member

/run-all-test

Member

coocood commented Oct 13, 2017

/run-all-test

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Oct 13, 2017

Member

Well done.

Member

ngaut commented Oct 13, 2017

Well done.

@coocood coocood merged commit 64bc8cb into master Oct 13, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.521%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the zz-jason/remove/eval branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment