New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger: simple improvement for range calc for pk. #4767

Merged
merged 18 commits into from Oct 24, 2017

Conversation

Projects
7 participants
@winoros
Member

winoros commented Oct 13, 2017

Now we have full ability to calculate the int primary key's range if no cast function occurs.
PTAL @coocood @hanfei1991 @lamxTyler

Show outdated Hide outdated expression/expression.go
Show outdated Hide outdated expression/expression.go
Show outdated Hide outdated util/ranger/new_refiner.go
Show outdated Hide outdated util/ranger/new_refiner.go
}
return accessConditions, filterConditions
}

This comment has been minimized.

@hanfei1991

hanfei1991 Oct 13, 2017

Member

ditto.

@hanfei1991
Show outdated Hide outdated expression/expression.go
Show outdated Hide outdated util/ranger/new_refiner.go

winoros and others added some commits Oct 13, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 13, 2017

Member

/run-all-tests

Member

shenli commented Oct 13, 2017

/run-all-tests

@hanfei1991 hanfei1991 added this to Others in Planner Oct 17, 2017

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros

winoros Oct 17, 2017

Member

ok i'll add this in test.

Member

winoros commented Oct 17, 2017

ok i'll add this in test.

},
{
exprStr: "a IS NOT FALSE",
resultStr: "[(-inf,-1] [1,+inf)]",
exprStr: "a = 1 or a = 3 or a = 4 or (a > 1 and (a = -1 or a = 5))",

This comment has been minimized.

@hanfei1991

hanfei1991 Oct 18, 2017

Member

and a case that a = 1 or a = 3 or a = 4 or (b > 1 and (a = -1 or a = 5))

@hanfei1991

hanfei1991 Oct 18, 2017

Member

and a case that a = 1 or a = 3 or a = 4 or (b > 1 and (a = -1 or a = 5))

@ngaut ngaut requested a review from coocood Oct 18, 2017

Show outdated Hide outdated util/ranger/new_refiner.go
Show outdated Hide outdated util/ranger/new_refiner.go
Show outdated Hide outdated expression/expression.go
Show outdated Hide outdated expression/expression.go

zimulala and others added some commits Oct 18, 2017

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros
Member

winoros commented Oct 18, 2017

PTAL @coocood

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Oct 19, 2017

Member

LGTM

Member

hanfei1991 commented Oct 19, 2017

LGTM

@hanfei1991 hanfei1991 moved this from Others to ranger in Planner Oct 19, 2017

@hanfei1991 hanfei1991 added this to the 1.1 milestone Oct 19, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991
Member

hanfei1991 commented Oct 19, 2017

@coocood PTAL

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 19, 2017

Member

/run-all-tests

Member

shenli commented Oct 19, 2017

/run-all-tests

@lamxTyler

This comment has been minimized.

Show comment
Hide comment
@lamxTyler

lamxTyler Oct 23, 2017

Member

@winoros Please resolve the conflict.

Member

lamxTyler commented Oct 23, 2017

@winoros Please resolve the conflict.

@lamxTyler

LGTM

@hanfei1991 hanfei1991 merged commit e96321b into master Oct 24, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.168%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the yiding/range branch Oct 24, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment