New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: estimate ndv as pseudo when its value is zero #4769

Merged
merged 4 commits into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@hanfei1991
Member

hanfei1991 commented Oct 13, 2017

Before we analyze table, the ndv is always 0. We should take it as count * distinct factor when we do estimation.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 15, 2017

Member

LGTM

Member

shenli commented Oct 15, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 15, 2017

Member

/run-all-tests

Member

shenli commented Oct 15, 2017

/run-all-tests

@lamxTyler

LGTM

@hanfei1991 hanfei1991 merged commit 7f0f43a into master Oct 16, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.491%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the hanfei/without-hist branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment