New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: improve the column info for client #4770

Merged
merged 9 commits into from Oct 15, 2017

Conversation

Projects
None yet
4 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Oct 13, 2017

XuHuaiyu and others added some commits Oct 13, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 13, 2017

Member

/run-all-tests

Member

shenli commented Oct 13, 2017

/run-all-tests

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 13, 2017

Member

LGTM

Member

coocood commented Oct 13, 2017

LGTM

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 15, 2017

Contributor

fix #4773

Contributor

XuHuaiyu commented Oct 15, 2017

fix #4773

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 15, 2017

Contributor

/run-integration-common-test
/run-common-test

Contributor

XuHuaiyu commented Oct 15, 2017

/run-integration-common-test
/run-common-test

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 15, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Oct 15, 2017

/run-all-test

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu
Contributor

XuHuaiyu commented Oct 15, 2017

Show outdated Hide outdated executor/executor_test.go Outdated
Show outdated Hide outdated expression/schema.go Outdated

XuHuaiyu added some commits Oct 15, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 15, 2017

Contributor

PTAL @shenli

Contributor

XuHuaiyu commented Oct 15, 2017

PTAL @shenli

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 15, 2017

Member

LGTM

Member

shenli commented Oct 15, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 15, 2017

Member

/run-all-tests

Member

shenli commented Oct 15, 2017

/run-all-tests

@shenli

shenli approved these changes Oct 15, 2017

@shenli shenli merged commit a34964a into master Oct 15, 2017

10 of 11 checks passed

jenkins-ci-tidb/unit-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.517%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@shenli shenli deleted the xhy/navicat branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment