New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb/tikv: return MySQL error code for Unsafe SafePoint #4786

Merged
merged 6 commits into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@atmzhou
Contributor

atmzhou commented Oct 16, 2017

When start timestamp of a transaction falls behind the safepoint, it returns MySQL Error Code. This indicates the user that larger GC Interval should be set.
When start timestamp of a transaction may fall behind the safepoint, it returns PDServerTimeout. This is the reason for aborting the transaction.

@atmzhou atmzhou requested a review from disksing Oct 16, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 16, 2017

Member

LGTM
Please update this doc.

Member

shenli commented Oct 16, 2017

LGTM
Please update this doc.

@disksing

LGTM.

@disksing disksing merged commit 0bf3614 into master Oct 17, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.529%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the ningnanzhou/errcode_safepoint branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment