New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: dummy implementation for show profiles statement #4795

Merged
merged 5 commits into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@tiancaiamao
Contributor

tiancaiamao commented Oct 17, 2017

Actually, show profiles is deprecated in MySQL, here we just return empty results.
Fix #2028

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 17, 2017

Member

LGTM

Member

coocood commented Oct 17, 2017

LGTM

@@ -4530,6 +4531,12 @@ ShowStmt:
}
$$ = stmt
}
| "SHOW" "PROFILES"

This comment has been minimized.

@shenli

shenli Oct 17, 2017

Member

Add test case in parser_test.go.

@shenli

shenli Oct 17, 2017

Member

Add test case in parser_test.go.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 17, 2017

Member

LGTM

Member

shenli commented Oct 17, 2017

LGTM

@shenli

shenli approved these changes Oct 17, 2017

@coocood coocood merged commit b9bf914 into master Oct 17, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the tiancaiamao/show-profile branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment