New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Update reorg wait time #4808

Merged
merged 3 commits into from Oct 19, 2017

Conversation

Projects
None yet
3 participants
@zimulala
Member

zimulala commented Oct 18, 2017

If we do add index, every 1ms we need to get the job information. I think it's wasteful.

@ngaut ngaut requested a review from breeswish Oct 18, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 18, 2017

Member

LGTM

Member

shenli commented Oct 18, 2017

LGTM

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala
Member

zimulala commented Oct 19, 2017

@breeswish

This comment has been minimized.

Show comment
Hide comment
@breeswish

breeswish Oct 19, 2017

Member

LGTM

Member

breeswish commented Oct 19, 2017

LGTM

@breeswish breeswish added status/LGT2 and removed status/LGT1 labels Oct 19, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Oct 19, 2017

Member

/run-all-tests

Member

zimulala commented Oct 19, 2017

/run-all-tests

@zimulala zimulala merged commit f1c82ac into master Oct 19, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.565%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zimulala zimulala deleted the zimuxia/reorg branch Oct 19, 2017

zimulala added a commit to zimulala/tidb that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment