New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: correct the signature building of Values #4814

Merged
merged 3 commits into from Oct 19, 2017

Conversation

Projects
None yet
4 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Oct 18, 2017

XuHuaiyu added some commits Oct 18, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 18, 2017

Member

LGTM

Member

shenli commented Oct 18, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 18, 2017

Member

/run-all-tests

Member

shenli commented Oct 18, 2017

/run-all-tests

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 18, 2017

Member

Please cherry-pick to release-1.0.

Member

shenli commented Oct 18, 2017

Please cherry-pick to release-1.0.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 18, 2017

Member

LGTM
Remember to send PR from your forked tidb repo next time.

Member

coocood commented Oct 18, 2017

LGTM
Remember to send PR from your forked tidb repo next time.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 18, 2017

Member

CI failed.

Member

shenli commented Oct 18, 2017

CI failed.

CI failed

@winkyao

LGTM

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao

winkyao Oct 19, 2017

Member

@XuHuaiyu Please fix ci,

Member

winkyao commented Oct 19, 2017

@XuHuaiyu Please fix ci,

@winkyao winkyao merged commit 3d6ec2a into master Oct 19, 2017

9 of 11 checks passed

jenkins-ci-tidb/common-test Jenkins job failed
Details
jenkins-ci-tidb/integration-common-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.57%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the xhy/sig branch Oct 19, 2017

XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment