New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: fix distinct bug. #4828

Merged
merged 2 commits into from Oct 19, 2017

Conversation

Projects
None yet
4 participants
@hanfei1991
Member

hanfei1991 commented Oct 19, 2017

When the query is select distinct, the root plan is aggregation, so its child projection should be eliminated.
This will fix #4819

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros

winoros Oct 19, 2017

Member

/run-all-test

Member

winoros commented Oct 19, 2017

/run-all-test

@winoros winoros added the status/LGT1 label Oct 19, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 19, 2017

Member

LGTM

Member

coocood commented Oct 19, 2017

LGTM

@jackysp jackysp merged commit b45890a into pingcap:master Oct 19, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.55%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Oct 30, 2017

@XuHuaiyu XuHuaiyu referenced this pull request Oct 30, 2017

Merged

cherry pick #4882 #4828 #4941

coocood added a commit that referenced this pull request Oct 30, 2017

cherry pick #4882 #4828 (#4941)
*  plan: join's default value length should be changed when do column pruning. (#4882)

* plan: fix distinct bug. (#4828)

@hanfei1991 hanfei1991 deleted the hanfei1991:hanfei/proj branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment