New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc_woker: start safePointChecker before run worker. #4845

Merged
merged 4 commits into from Oct 23, 2017

Conversation

Projects
None yet
4 participants
@disksing
Member

disksing commented Oct 20, 2017

If tidb is not able to finish bootstrap in 100 seconds, the safePointChecker will not be started, then all transactions are not able to execute.

@disksing disksing requested review from shenli, tiancaiamao and atmzhou Oct 20, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Oct 20, 2017

@coocood PTAL

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Oct 23, 2017

Member

LGTM

Member

ngaut commented Oct 23, 2017

LGTM

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 23, 2017

Member

LGTM

Member

coocood commented Oct 23, 2017

LGTM

coocood and others added some commits Oct 23, 2017

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing
Member

disksing commented Oct 23, 2017

PTAL @shenli

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 23, 2017

Member

LGTM

Member

shenli commented Oct 23, 2017

LGTM

@shenli

shenli approved these changes Oct 23, 2017

@shenli shenli merged commit ed6c704 into pingcap:master Oct 23, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing:gcworker branch Oct 23, 2017

disksing added a commit to disksing/tidb that referenced this pull request Oct 23, 2017

shenli added a commit to shenli/tidb that referenced this pull request Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment